-
Couldn't load subscription status.
- Fork 8
Company page template #35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Company page template #35
Conversation
nienn
commented
Jan 20, 2022
- Merge after Pricing page template #34
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I only had time to do a partial review here. I think we could shape up the content this page has, but we have good sources for this already in our docs.
| 101.22,112.105 97.497,107.212 48.921,119.538 56.013,125.224 97.852,116.218 79.946,127.707 48.212,112.991 "/> | ||
| </g> | ||
| </g> | ||
| </svg> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we're using this file, are we? If this is used for the contributors, I'd pull those icons in, or just use the images directly from github.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nop. This file is just a default image that can be used either as a placeholder or whenever the user image is missing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gotcha. I don't think we'd have any missing user icons, and can at least prune out any we don't like. So seems safe to remove.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
File removed with PR d9b2291 along with contributors' images src referencing it as a placeholder.
I think it's useful to have default images for most cases but it's not indispensable.
| <div class="ui segment basic mini"> | ||
| <h6 class="ui header">Latest blog posts:</h6> | ||
| <div> | ||
| <b><a href="https://blog.readthedocs.com/newsletter-december-2021/">Read the Docs newsletter - December 2021</a></b> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we automating this listing here to? It's also fine to just link to the blog section, or return to this when we can automate a blog listing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is definitely something that can be automated once the blog migrates here.
Until then probably doesn't make much sense to automate and we can just link to the blog section.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done here e0c5dd4. I used the text "Check it out" for the blog link.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The middle column, talking about the docs, has now a very disproportional text length, but I'm not sure if we should revise that copy accordingly only to change it back as soon as the blog is done and this content is updated back.
Co-authored-by: Anthony <[email protected]>